Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

Conversation

@marco-c
Copy link
Contributor

@marco-c marco-c commented Nov 11, 2015

Fixes #160.

@marco-c
Copy link
Contributor Author

marco-c commented Nov 11, 2015

Filed #169 to use gulp-install when (and if) slushjs/gulp-install#32 is merged.

@marco-c
Copy link
Contributor Author

marco-c commented Nov 11, 2015

First part of the output:
bootstrap_initial

Error while installing npm dependencies:
bootstrap_error

I know the error is logged twice, but there's #150 about it (and I didn't want to suppress errors because it could have unintended consequences. Better to log it twice than never).

Success:
bootstrap_success

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per that issue @wfwalker ran into with configure, I guess this should be git add --all && git commit -m"initial version of Oghliner app".

@mykmelez mykmelez merged commit d6b5a5b into mozilla:master Nov 12, 2015
@mykmelez
Copy link
Contributor

In the interest of landing this to unblock other pull requests, I corrected #168 (comment) in 5f93c0d and merged this manually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants