Skip to content

[component] Changed classification from Fenix::General to GeckoView::General #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benjaminmah wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[component] Changed classification from Fenix::General to GeckoView::General #2588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bugbot/rules/component.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ def meets_threshold(bug_data):
confidence = data["prob"][data["index"]]

if confidence > self.fenix_confidence_threshold:
data["class"] = f"Fenix::{data['class']}"
if data["class"] == "General":
data["class"] = "GeckoView::General"
else:
data["class"] = f"Fenix::{data['class']}"
Comment on lines -131 to +134
Copy link
Member

@suhaibmujahid suhaibmujahid Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminmah is this still relevant?

Copy link
Contributor Author

@benjaminmah benjaminmah Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the conversation with Marco here: mozilla/bugbug#4682 (comment), we can leave as it is. However, I was under the impression that we wanted the Fenix model to move bugs to GeckoView as well.

Copy link
Contributor Author

@benjaminmah benjaminmah Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suhaibmujahid I was thinking we could just close this PR for now. WDYT?

bugs[bug_id] = data

results = {}
Expand Down