Add live span column to the graph.#34
Open
nbp wants to merge 1 commit intomozilla-spidermonkey:mainfrom
Open
Conversation
This change adds a 2px wide column which is used to highlight the life span, between the last uses and the definition of the selected values. It does so, by using a fix-point over the displayed graph, which will record the set of instructions which are live at the end of each block, and for each block computes the live set of each predecessor by walking the instruction backward, and recording the live ranges of every instructions along the way. The memory representation can probably be optimized later.
Contributor
Author
|
I will look at these warnings later … |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a 2px wide column which is used to highlight the life span, between the last uses and the definition of the selected values.
It does so, by using a fix-point over the displayed graph, which will record the set of instructions which are live at the end of each block, and for each block computes the live set of each predecessor by walking the instruction backward, and recording the live ranges of every instructions along the way. The memory representation can probably be optimized later.
At the moment, there is only one column, and selecting multiple instructions will overwrite the previous one. Also, a 2 pixels wide view does not offer much opportunities for distinguishing colors such as pink and orange.
I have not yet tried with gigantic graphs, and I suspect there could be some memory / performance issue with this naive implementation.