Make RecoveredOnBailout appear#33
Merged
bvisness merged 1 commit intomozilla-spidermonkey:mainfrom Mar 9, 2026
Merged
Conversation
Collaborator
|
The CSS looks fine, but do we need all the Nix stuff? I don't use it and have zero idea how to maintain it. |
Contributor
Author
|
The nix stuff is things that I have locally to avoid touching npm. |
CSS property for moveable appearing last in style.css implies that recovered-on-bailout annotation was not displayed. Having an instruction flagged as recovered-on-bailout being more important than being moveable, moving the style definition later in the file make it take precedence. Text decoration is also added to make it clear that while the instruction remains in the SSA graph, it is effectively unused during the execution. This is denoted by using a wavy line-through.
nbp
force-pushed
the
where-is-recovered-on-bailout
branch
from
73bb17c to
08c8243
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, instructions flagged as recovered-on-bailout are never be visible, because most instructions are moveable.