ae1120 -- add firefox_version metric for interaction and request-stats pings #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleonard-m
approved these changes
Jan 9, 2026
dmueller
reviewed
Jan 9, 2026
Comment on lines
317
to
318
| Version of the Firefox browser being used by the client. Used for error investigation only, no | ||
| analytics value. |
Contributor
There was a problem hiding this comment.
Used for error investigation only, no analytics value.
this phrase feels kind of meaningless -- if we populate the field in the table then it can be queried, and then there will be things with a dependency on it. I get that this phrasing was used because it's the same one that some of our other metrics have, but I kind of feel like we should remove it.
Once a field exists in a glean table, there's no sentiment-based restriction that exists when querying it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: https://mozilla-hub.atlassian.net/browse/AE-1120