docs: add explicit data_sensitivity values to all metrics #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To date, we have not been using the optional
data_sensitivityfield in ourmetrics.yaml.Until now it has been implicitly pretty clear what kind of data we're working with -- anything in the Interaction pings is
interactiondata, and anything in RequestStats style pings istechnical, with metrics explicitly grouped undertechnical_operations.While going through the data review process for adding DMA codes throughout the pings, which may have a higher sensitivity, reviewers noted that it would be helpful and timely to now explicitly include the
data_sensitivityfield throughout. This change addresses that feedback.Please take a look and double check that I've set the correct values throughout.