This repository was archived by the owner on Mar 28, 2019. It is now read-only.
Distinguish before/after events #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.rst
Outdated
|
|
||
| **Breaking changes** | ||
|
|
||
| - Errors are not swallowed during execution of ``ResourceChanged`` subscribers |
Contributor
There was a problem hiding this comment.
nit: are not swallowed anymore during the execution of [...]
leplatrem
force-pushed
the
add-post-commits-events
branch
from
a81abe7 to
d2f32ce
Compare
|
|
||
|
|
||
| class AfterResourceChanged(_ResourceEvent): | ||
| """Triggered after a resource was successfully changed. |
Contributor
There was a problem hiding this comment.
Add a note here explaining that we can be sure it this point that the resource was really changed and commited to the database.
Contributor
|
LGTM but lacks documentation (I see there is some in the CHANGELOG but I don't believe that's enough) |
leplatrem
force-pushed
the
add-post-commits-events
branch
from
d2f32ce to
d1a62f0
Compare
Contributor
Author
|
I'm puzzled : View transactions tests pass when I run them isolated: But they don't if I run the whole test suite |
Contributor
Author
|
Ok, found it. In |
leplatrem
force-pushed
the
add-post-commits-events
branch
from
6910215 to
8f321ad
Compare
3 tasks
|
|
||
| Subscribers of this event are likely to perform database operations, | ||
| alter the server response, or cancel the transaction (by raising an HTTP | ||
| exeception for example). |
Contributor
|
Great job r+ with nit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(revamp of #644)
Change subscribtion of listeners toRun listeners using subprocess running in background #647AfterResourceChanged(because of fire-n-forget)tldr: We need two kinds of events:
beforeevents to run within transaction and «rollbackable».afterevents to run irreversible actions (that can fail)Feedback/Critics/Stones/Hugs/Flowers welcome!