Skip to content

Conversation

@jcristau
Copy link
Contributor

No description provided.

@jcristau jcristau requested a review from a team as a code owner January 22, 2026 18:03
@jcristau
Copy link
Contributor Author

Actually, comparing the images before/after this doesn't seem to change anything.

https://firefoxci.taskcluster-artifacts.net/DukW0u4iRg2l6Dd4hMQ6AA/0/public/logs/live_backing.log is a log without this and there's no trace of the dev dependencies. I don't understand why, but hey...

Copy link
Contributor

@Eijebong Eijebong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was already not installing dev dependencies because shipit is a workspace. Dependency groups are per project and syncing deps at the root will only consider extra groups from said root. It syncs normal dependencies because the root "depends" on its children but groups are not even considered in that AFAICT. If you run uv sync at the root then in api/ you'll see it add dev deps.
See: astral-sh/uv#12312 (comment)

So this is correct, it'll help in case we ever add dependency groups at the root, even if it's a noop right now.

@jcristau
Copy link
Contributor Author

Good find! (Makes me wonder if what we want is actually something like uv sync --project api --no-dev --frozen? Same result I guess, given that shipit-api is the only dep at the root.)

@Eijebong
Copy link
Contributor

Yeah I'm not sure why it's a workspace in the first place tbh

@jcristau jcristau merged commit 9ef851c into mozilla-releng:main Jan 23, 2026
7 checks passed
@jcristau jcristau deleted the no-dev-deps-in-prod-thank-you-very-much branch January 23, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants