Conversation
arcturus
left a comment
arcturus
left a comment
There was a problem hiding this comment.
I had to manually run pod install could you add this step to the npm postinstall? We are already running carthage there.
|
|
||
| class MagnetScanner: NSObject { | ||
| var scanner: MagnetScannerIOS.MagnetScanner!; | ||
| var callback: ((Dictionary<String, AnyObject>) -> Void)! |
There was a problem hiding this comment.
Do we need to save an instance of the callback?
| <string>en</string> | ||
| <key>CFBundleDisplayName</key> | ||
| <string>MagnetWidget</string> | ||
| <string>Magnet</string> |
There was a problem hiding this comment.
Can you change it to 'Project Magnet'
|
|
||
| self.table.reloadData(); | ||
| // Get url metadata. | ||
| let metadataServer: String = "https://tengam.org/api/v1/metadata"; |
There was a problem hiding this comment.
Should we set this as a constant class attribute?
| let task = session.dataTaskWithRequest(request, completionHandler: { | ||
| (data, response, error) in | ||
| guard error == nil else { | ||
| print("Error: metadata server error", error); |
There was a problem hiding this comment.
Perhaps we should do debugPrint here too, I know those are proper errors, but just to keep user's console clean.
| # Uncomment this line to define a global platform for your project | ||
| # platform :ios, '9.0' | ||
|
|
||
| target 'Magnet' do |
There was a problem hiding this comment.
Uh! Now we need both cocoapods and carthage?
| } | ||
|
|
||
| class MagnetMetadataClient: NSObject { | ||
| let metadataServerUrl: NSURL = NSURL(string: "https://tengam.org/api/v1/metadata")!; |
|
In order to compile this, I had to manually add the folder SwiftSerializer from Pods into the dependencies. |
2 participants
No description provided.