Open
Conversation
workaround per getmoto/moto#4687
Old mock depends on an internal param removed in 0.18.0 Some sort of NoneType error added by 0.12.1
one of the old deps is triggering getmoto/moto#3535
floatingatoll
force-pushed
the
fix-ci
branch
from
10d3517 to
52fdf40
Compare
bkochendorfer
approved these changes
Nov 17, 2022
Member
bkochendorfer
left a comment
bkochendorfer
left a comment
There was a problem hiding this comment.
Good work! Yeah I think you can give it a go if it passses!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bkochendorfer, I'm trying to prepare for a release of CIS for IAM-994, and it took a lot of old-version pinning and various Docker/CI/etc. work to get the tests to mostly pass (except for postgresql, which I guess was already known).
I believe since the work in June, that the deprecation of Python2 on archlinux led to this subsequent "pin old versions now that python3 is in use" effort.
Do you think this is safe to merge and do a serverless deploy from, so that we can start repairing the timezone data?