chore: set checkLocalVariables to true on jsx-handler-names rules#91
chore: set checkLocalVariables to true on jsx-handler-names rules#91ruimonteiro93 wants to merge 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 33 33
Lines 42 42
Branches 1 1
=========================================
Hits 42 42
Continue to review full report at Codecov.
|
|
While not intentional, this is a breaking change correct? |
|
We are missing a test in https://github.com/moxystudio/eslint-config/blob/master/packages/eslint-config-react/test/rules/react.js. |
| Object { | ||
| "column": 43, | ||
| "line": 4, | ||
| "rule": "react/jsx-handler-names", |
There was a problem hiding this comment.
This error shouldn't happen as the function is anonymous.. I guess that's a deal breaker for now, see: jsx-eslint/eslint-plugin-react#2586
|
@ruimonteiro93, what's the status of this? Please follow up. |
|
@acostalima we can’t merge this until #91 (comment) is solved. |
3 participants
This is to ensure that all event handlers are properly named, according to the rules specified.