fix(android): resolve MediaPlayer lifecycle bugs and remove deprecated Android style usage

[MattyB95]

Summary

This PR fixes several Android MediaPlayer lifecycle issues that could cause crashes, duplicate callbacks, silent failures, and resource leaks. It also removes deprecated style usage and adds regression tests for the corrected error-handling paths.

Changes

• Replace deprecated Theme_NoTitleBar with Theme_Black_NoTitleBar_Fullscreen
• Replace blocking prepare() with prepareAsync()
• Fix onError() returning false, which triggered onCompletion() and caused double release() / dismiss()
• Fix missing JavaScript error callback invocation in onError()
• Null out player and dialog after release to prevent duplicate callbacks and potential NPEs
• Explicitly close AssetFileDescriptor after asset playback
• Add returnDefaultValues = true to support Android framework stubbed paths in unit tests
• Add VideoPlayerOnErrorTest regression coverage for the fixed onError() behaviour

Fixes #71 #73 #75

[Copilot]

Pull request overview

This PR hardens the Android MediaPlayer lifecycle in the Cordova VideoPlayer plugin (preventing double-callbacks/leaks/crashes), removes deprecated fullscreen handling, and adds an Android Gradle-based unit test harness with regression coverage.

Changes:

• Fix Android playback lifecycle behavior (async prepare, error handling, safe release/dismiss, asset FD closure, API-safe fullscreen).
• Add Android unit tests and a standalone Gradle test project under tests/android.
• Update docs/metadata (Android-only support, permissions guidance, npm/just test commands, cleanup .gitignore).

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/android/VideoPlayer.java	Lifecycle fixes: async prepare, safer close/error/completion cleanup, API-safe fullscreen via reflection, shared sendError helper.
www/videoplayer.js	Replace custom merge with Object.assign-based options merge.
tests/android/build.gradle	Introduces Android Gradle test module compiling plugin source and running JUnit/Mockito tests.
tests/android/gradlew	Adds Gradle wrapper script for test project.
tests/android/gradle/wrapper/*	Adds wrapper jar/properties for pinned Gradle distribution.
tests/android/src/test/java/*	Adds regression tests for stripFileProtocol, applyFullscreen, and onError behavior.
tests/android/src/test/resources/...MockMaker	Configures Mockito mock maker for unit tests.
tests/android/src/main/AndroidManifest.xml	Minimal manifest for the test module.
tests/android/settings.gradle	Settings for the test Gradle project.
package.json	Updates metadata (Android-only) and adds npm test to run Android unit tests.
README.md	Updates docs (Android-only, permissions, troubleshooting).
.gitignore	Replaces legacy ignores with common OS/editor/Android/Node ignores.
justfile	Adds convenience tasks for running tests/lint/report/validation.

Comments suppressed due to low confidence (1)

src/android/VideoPlayer.java:278

• prepareAsync() makes onPrepared() asynchronous relative to close() / surfaceDestroyed() which can release/null out the player. As written, mp.start() can throw IllegalStateException if the player was released before the callback fires. Add a guard (e.g., return if player == null or mp != player) and/or wrap start() in a try/catch to avoid lifecycle race crashes.

    @Override
    public void onPrepared(MediaPlayer mp) {
        mp.start();
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.