Add test for variety of date/time stamps #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using this library in Seattle, WA, USA it was found that date objects with a small time (example: 00:01:00) would be interpreted by the library as occurring the day before. This test exposes the problem, but does not offer a solution. It's assumed the issue is somewhere in toJulian() and toDays(), but this author does not understand them well enought to venture in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library in Seattle, WA, USA it was found that date objects with a small time (ex: 00:01:00) would be interpreted by the library as occurring the day before.
This test exposes the problem, but unfortunately it doesn't offer a solution (guessing the issue is with
toJulian()andtoDays()?)