Fix nav link click behavior #1446
Conversation
…d resources menu link from causing scroll to top of page
There was a problem hiding this comment.
Pull Request Overview
This PR fixes navigation link behavior issues where section links were opening in new windows instead of scrolling to sections, and the related resources menu link was causing unwanted scrolling to the top of the page.
- Updated link click logic to check for valid scroll targets before opening external links
- Added preventDefault() to menu click handler to stop default anchor behavior
- Reorganized conditional flow for better readability and correct functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| router.push(href, { scroll: false }) | ||
| window.scrollTo({ | ||
| top: el.offsetTop - NavBarHeights[breakpoint].condensed, | ||
| behavior: 'smooth', | ||
| }) |
There was a problem hiding this comment.
The router.push() call will always execute when an element is found, even for external URLs that contain hash fragments. This could cause navigation issues if href contains an external URL with a hash (e.g., 'https://example.com#section'). Consider checking if the href is an internal route before calling router.push().
| router.push(href, { scroll: false }) | |
| window.scrollTo({ | |
| top: el.offsetTop - NavBarHeights[breakpoint].condensed, | |
| behavior: 'smooth', | |
| }) | |
| if (isInternalUrl(href)) { | |
| router.push(href, { scroll: false }) | |
| window.scrollTo({ | |
| top: el.offsetTop - NavBarHeights[breakpoint].condensed, | |
| behavior: 'smooth', | |
| }) | |
| } else { | |
| // For external URLs, just open in a new tab | |
| window.open(href, '_blank'); | |
| return; | |
| } |
|
Thanks @maflaven! this appears to be a bug i introduced recently. I noticed this the other day as I have finally started working on the multi-page site & project explorer. Stay tuned for more exciting new bugs! |
|
Oh sweet! Looking forward to it! |
Hey yall, hope everyone's doing well!
I noticed nav links for sections on the main page will open another window instead of just scrolling to the matching section. Also clicking related resources menu link triggers a scroll to the top of the page (in addition to opening the menu). Added some changes to prevent both of these.