feat: replace CustomRuntimeException with SecurityException for exist… #340

jbh010204 · 2025-08-12T15:49:57Z

…ing Mosu users in OAuthUserService

✨ 구현한 기능

📢 논의하고 싶은 내용

🎸 기타

…ing Mosu users in OAuthUserService

coderabbitai · 2025-08-12T15:50:05Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

gemini-code-assist

Summary of Changes

Hello @jbh010204, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the exception handling within the OAuthUserService. The primary change involves replacing a custom runtime exception with a standard Java security exception when an existing Mosu user attempts to log in via OAuth. This aims to standardize the exception type for this specific scenario, improving consistency with Java's built-in exception hierarchy.

Highlights

Exception Type Refactoring: The CustomRuntimeException, previously used for signaling an existing Mosu user during OAuth login, has been replaced with the standard Java SecurityException.
Code Clean-up: The imports for CustomRuntimeException and ErrorCode were removed from OAuthUserService.java as they are no longer utilized after the exception type change.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

안녕하세요. CustomRuntimeException을 SecurityException으로 변경하여 기존 모수 회원의 OAuth 로그인 시도를 처리하는 변경 사항을 확인했습니다. 이 변경으로 기존의 사용자 정의 예외 처리 방식에서 스프링 시큐리티의 인증 실패 처리 흐름을 따르도록 의도하신 것으로 보입니다. 좋은 방향의 변경이라고 생각합니다. 다만, SecurityException은 다소 일반적인 예외이므로, 스프링 시큐리티에서 제공하는 더 명확한 의미의 예외를 사용하는 것을 제안합니다. 자세한 내용은 코드 리뷰 댓글을 참고해주세요.

gemini-code-assist · 2025-08-12T15:51:15Z

src/main/java/life/mosu/mosuserver/application/oauth/OAuthUserService.java

        if (oAuthUser.isMosuUser()) {
            log.info("모수 회원으로 가입된 사용자입니다: {}", oAuthUser.getLoginId());
-            throw new CustomRuntimeException(ErrorCode.ALREADY_MOSU_USER);
+            throw new SecurityException();


현재 SecurityException을 사용하고 계신데, 이 예외는 자바 보안 모델과 관련이 깊어 현재 컨텍스트에는 의미가 명확하게 와닿지 않을 수 있습니다.

스프링 시큐리티의 예외 계층 구조를 활용하여 더 의미가 명확한 예외를 사용하는 것을 추천합니다. 예를 들어, AuthenticationServiceException은 인증 처리 중 발생하는 서비스 레벨의 문제를 나타내는 데 사용됩니다. "이미 가입된 사용자가 소셜 로그인을 시도하는 경우"를 서비스 로직 상의 인증 실패 케이스로 보고 이 예외를 사용하면 코드의 의도를 더 잘 드러낼 수 있습니다.

이렇게 변경하면 스프링 시큐리티의 표준 인증 실패 처리 흐름을 따르면서도, 나중에 코드를 유지보수할 때 예외의 원인을 파악하기 용이해집니다.

다음과 같이 변경하는 것을 제안합니다. (이 경우 org.springframework.security.authentication.AuthenticationServiceException 임포트가 필요합니다.)

Suggested change

throw new SecurityException();

throw new AuthenticationServiceException("모수 회원으로 가입된 사용자입니다. 일반 로그인을 이용해주세요.");

feat: replace CustomRuntimeException with SecurityException for exist…

fcaecf1

…ing Mosu users in OAuthUserService

jbh010204 merged commit 7afc334 into prod Aug 12, 2025
4 of 5 checks passed

gemini-code-assist bot reviewed Aug 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: replace CustomRuntimeException with SecurityException for exist… #340

feat: replace CustomRuntimeException with SecurityException for exist… #340

Uh oh!

jbh010204 commented Aug 12, 2025

Uh oh!

coderabbitai bot commented Aug 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	throw new SecurityException();
	throw new AuthenticationServiceException("모수 회원으로 가입된 사용자입니다. 일반 로그인을 이용해주세요.");

feat: replace CustomRuntimeException with SecurityException for exist… #340

feat: replace CustomRuntimeException with SecurityException for exist… #340

Uh oh!

Conversation

jbh010204 commented Aug 12, 2025

✨ 구현한 기능

📢 논의하고 싶은 내용

🎸 기타

Uh oh!

coderabbitai bot commented Aug 12, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)