-
Notifications
You must be signed in to change notification settings - Fork 1
prod: 모수 사용자 카카오 로그인 안되게 예외 처리 #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @jbh010204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 기존 모수(Mosu) 사용자가 카카오 계정을 통해 로그인하는 것을 방지하기 위한 예외 처리 로직을 추가합니다. 이는 이미 서비스에 가입된 사용자가 OAuth를 통해 중복 로그인하거나 계정 연동에 혼란을 겪는 것을 막기 위함으로 보입니다.
Highlights
- 카카오 로그인 시 기존 모수 사용자 차단: OAuthUserService에서 카카오 로그인을 처리할 때, 로그인하려는 사용자가 이미 모수 회원으로 등록되어 있다면 ALREADY_MOSU_USER 예외를 발생시켜 로그인을 허용하지 않습니다.
- 새로운 에러 코드 정의: ErrorCode enum에 ALREADY_MOSU_USER라는 새로운 에러 코드를 추가하여, 이미 모수 회원인 경우에 대한 명확한 응답과 메시지를 제공합니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
안녕하세요. 모수 회원의 카카오 로그인을 막는 예외 처리 추가 PR 잘 보았습니다. 로직을 OAuthUserService로 옮겨 책임 분리를 명확히 한 점이 좋습니다. 코드 품질을 더 높이기 위해 몇 가지 제안 사항을 남깁니다.
| /** | ||
| * this method is processing OAuthUserInfo to UserJpaEntity that is Get or Create. | ||
| * | ||
| * @param info | ||
| * @return | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc의 가독성을 높이기 위해 내용을 조금 더 명확하게 수정하는 것을 제안합니다. 예를 들어, 현재의 'this method is processing...' 대신 메서드의 역할을 명확히 설명하고 파라미터와 반환 값에 대한 설명도 추가하면 좋겠습니다.
| /** | |
| * this method is processing OAuthUserInfo to UserJpaEntity that is Get or Create. | |
| * | |
| * @param info | |
| * @return | |
| */ | |
| /** | |
| * 주어진 OAuthUserInfo를 처리하여 기존 사용자를 찾거나 새로 생성합니다. | |
| * | |
| * @param info OAuth 사용자 정보 | |
| * @return 조회 또는 생성된 사용자 엔티티 | |
| */ |
| // if (existingUser.isMosuUser()) { | ||
| // throw new IllegalArgumentException("이미 모수 회원입니다."); | ||
| // } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타