Skip to content

Conversation

@jbh010204
Copy link
Member

✨ 구현한 기능

📢 논의하고 싶은 내용

🎸 기타

@coderabbitai
Copy link

coderabbitai bot commented Aug 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jbh010204 jbh010204 merged commit d605503 into prod Aug 12, 2025
4 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jbh010204, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 기존 모수(Mosu) 사용자가 카카오 계정을 통해 로그인하는 것을 방지하기 위한 예외 처리 로직을 추가합니다. 이는 이미 서비스에 가입된 사용자가 OAuth를 통해 중복 로그인하거나 계정 연동에 혼란을 겪는 것을 막기 위함으로 보입니다.

Highlights

  • 카카오 로그인 시 기존 모수 사용자 차단: OAuthUserService에서 카카오 로그인을 처리할 때, 로그인하려는 사용자가 이미 모수 회원으로 등록되어 있다면 ALREADY_MOSU_USER 예외를 발생시켜 로그인을 허용하지 않습니다.
  • 새로운 에러 코드 정의: ErrorCode enum에 ALREADY_MOSU_USER라는 새로운 에러 코드를 추가하여, 이미 모수 회원인 경우에 대한 명확한 응답과 메시지를 제공합니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. 모수 회원의 카카오 로그인을 막는 예외 처리 추가 PR 잘 보았습니다. 로직을 OAuthUserService로 옮겨 책임 분리를 명확히 한 점이 좋습니다. 코드 품질을 더 높이기 위해 몇 가지 제안 사항을 남깁니다.

Comment on lines +19 to +24
/**
* this method is processing OAuthUserInfo to UserJpaEntity that is Get or Create.
*
* @param info
* @return
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Javadoc의 가독성을 높이기 위해 내용을 조금 더 명확하게 수정하는 것을 제안합니다. 예를 들어, 현재의 'this method is processing...' 대신 메서드의 역할을 명확히 설명하고 파라미터와 반환 값에 대한 설명도 추가하면 좋겠습니다.

Suggested change
/**
* this method is processing OAuthUserInfo to UserJpaEntity that is Get or Create.
*
* @param info
* @return
*/
/**
* 주어진 OAuthUserInfo를 처리하여 기존 사용자를 찾거나 새로 생성합니다.
*
* @param info OAuth 사용자 정보
* @return 조회 또는 생성된 사용자 엔티티
*/

Comment on lines +31 to +33
// if (existingUser.isMosuUser()) {
// throw new IllegalArgumentException("이미 모수 회원입니다.");
// }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

주석 처리된 코드가 남아있습니다. 이 로직은 OAuthUserService로 이동되었으므로, 혼동을 피하고 코드를 깔끔하게 유지하기 위해 이 주석 블록을 제거하는 것이 좋습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants