prod: develop to prod

[jbh010204]

✨ 구현한 기능

📢 논의하고 싶은 내용

🎸 기타

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[gemini-code-assist]

Summary of Changes

Hello @jbh010204, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request merges the develop branch into prod, incorporating several key updates. These changes include a refinement to the exam application query logic, a significant refactoring of the IP address utility class for improved robustness and readability, and the addition of a validation rule to limit the number of attachments in inquiry requests.

Highlights

• Exam Application Query Logic Update: The JPQL query in ExamApplicationJpaRepository has been adjusted to correctly filter exam applications based on payment and refund statuses, and to exclude soft-deleted entries.
• IP Address Utility Refactoring: The IpUtil class has been refactored to streamline the process of retrieving client IP addresses, utilizing a more robust header parsing mechanism and properly handling loopback addresses.
• Inquiry Attachment Limit: A new validation rule has been added to InquiryCreateRequest to enforce a maximum of three attachments per inquiry.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

이 PR은 몇 가지 개선 사항과 버그 수정을 포함하고 있습니다.

• ExamApplicationJpaRepository: 결제 및 환불 상태를 조회하는 쿼리 로직이 수정되었습니다. 이로 인해 이전에 제외되었던 환불 실패 건도 올바르게 조회될 것으로 보입니다. 다만, 쿼리의 가독성과 견고성을 높이기 위한 제안을 리뷰 코멘트로 남겼습니다.
• IpUtil: 클라이언트 IP 주소를 가져오는 유틸리티 클래스가 스트림과 enum을 활용하여 가독성과 유지보수성이 높도록 리팩토링되었습니다. 이는 매우 긍정적인 변화입니다.
• InquiryCreateRequest: 문의 생성 요청 시 첨부 파일의 최대 개수를 제한하는 유효성 검사 로직이 추가되어 안정성이 향상되었습니다.

전반적으로 코드 품질을 개선하는 좋은 변경 사항들입니다. 아래의 리뷰 코멘트를 확인해주세요.

[gemini-code-assist]

현재 WHERE 절의 (p.paymentStatus = 'DONE' OR r.refundStatus = 'DONE') 조건은 논리적으로 p.paymentStatus = 'DONE'과 동일한 결과를 반환할 것으로 보입니다. 환불이 완료(r.refundStatus = 'DONE')되려면 반드시 결제가 먼저 완료(p.paymentStatus = 'DONE')되어야 하기 때문입니다.

OR를 사용한 현재 조건은 혼란을 줄 수 있으며, 데이터 무결성이 깨진 예외적인 경우(결제 미완료 상태에서 환불 완료)에 의도치 않은 동작을 유발할 수 있습니다. 또한, OR 조건은 데이터베이스 쿼리 성능에 미미한 영향을 줄 수도 있습니다.

코드를 더 명확하고 견고하게 만들기 위해 조건을 p.paymentStatus = 'DONE'으로 단순화하는 것을 제안합니다. 이렇게 하면 결제가 완료된 모든 신청을 조회하며, CASE 문을 통해 환불 상태를 정확히 표시할 수 있습니다.

Suggested change

	WHERE (p.paymentStatus = 'DONE' OR r.refundStatus = 'DONE')
	WHERE p.paymentStatus = 'DONE'