-
Notifications
You must be signed in to change notification settings - Fork 0
Fix#388 학교 경쟁 페이지 및 순위 테이블 스타일 변경 #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughPrecomputed and exposed top3Schools and sorted topRatedSchools in getStaticProps. Updated page props accordingly. RankTableSection now computes prevRank and gap numerically per row and passes them to RankTableRow. RankTableRow’s API changed from gapMessage to prevRank and gap, altering the last cell rendering. Minor text tweak in InfoSection. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Next.js as Next.js (build)
participant Page as SchoolCompetitionPage
participant RankList as RankListSection
participant RankTable as RankTableSection
participant Row as RankTableRow
Next.js->>Next.js: getStaticProps()\n- sort topRatedSchools\n- derive top3Schools
Next.js-->>Page: props { top3Schools, topRatedSchools }
User->>Page: Request /events/competition
Page->>RankList: props { top3Schools }
Page->>RankTable: props { topRatedSchools }
loop for each school (i)
RankTable->>Row: props { rank=i+1, schoolName, prevRank=i, gap=diff vs prev }
Row-->>RankTable: render row with "{prevRank}등까지" and gap
end
RankTable-->>Page: table rendered
Page-->>User: HTML
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 추가 및 변경된 파일총 4개 파일 변경 |
📚 Storybook이 Chromatic에 배포되었습니다!
|
✅ Linked Issue
Summary by CodeRabbit
New Features
Style