-
Notifications
You must be signed in to change notification settings - Fork 0
Fix#388 topRatedSchools 정렬 로직 추가 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. WalkthroughgetStaticProps in the competition page now sorts topRatedSchools by paidApplicationCount in descending order before returning props. The revalidate interval remains 3600. Downstream components (e.g., RankTableSection and top-3 extraction) will receive and operate on the pre-sorted array. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant N as Next.js (SSG)
participant DS as Data Source
participant P as Competition Page
participant RT as RankTableSection
U->>N: Request /events/competition
Note over N: If ISR revalidate (3600s) expired
N->>DS: fetch topRatedSchools
DS-->>N: topRatedSchools (unsorted)
Note over N: Sort by paidApplicationCount desc
N-->>U: Serve HTML with sorted props
U->>P: Load page with props
P->>P: Extract top3 from sorted list
P->>RT: Render table with sorted data
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 추가 및 변경된 파일총 1개 파일 변경 |
📚 Storybook이 Chromatic에 배포되었습니다!
|
✅ Linked Issue
Summary by CodeRabbit