Skip to content

Conversation

@toothlessdev
Copy link
Member

@toothlessdev toothlessdev commented Sep 8, 2025

✅ Linked Issue

Summary by CodeRabbit

  • Bug Fixes
    • Corrected school ranking order on the Competition page. The Leaderboard and Top 3 now consistently display schools from highest to lowest based on paid applications, fixing previously inconsistent/unsorted views. This ensures accurate, fair rankings across sections. Data continues to refresh hourly.

@vercel
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
mosu-client Ready Ready Preview Comment Sep 8, 2025 5:18pm

@toothlessdev toothlessdev merged commit f5b5372 into main Sep 8, 2025
5 of 6 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

getStaticProps in the competition page now sorts topRatedSchools by paidApplicationCount in descending order before returning props. The revalidate interval remains 3600. Downstream components (e.g., RankTableSection and top-3 extraction) will receive and operate on the pre-sorted array.

Changes

Cohort / File(s) Summary
Competition page data sorting
mosu-app/src/pages/events/competition/index.tsx
Added pre-return sort of topRatedSchools by paidApplicationCount descending within getStaticProps. revalidate unchanged (3600). Affects order consumed by RankTableSection and top-3 derivation.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor U as User
    participant N as Next.js (SSG)
    participant DS as Data Source
    participant P as Competition Page
    participant RT as RankTableSection

    U->>N: Request /events/competition
    Note over N: If ISR revalidate (3600s) expired
    N->>DS: fetch topRatedSchools
    DS-->>N: topRatedSchools (unsorted)
    Note over N: Sort by paidApplicationCount desc
    N-->>U: Serve HTML with sorted props

    U->>P: Load page with props
    P->>P: Extract top3 from sorted list
    P->>RT: Render table with sorted data
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled through arrays so neat,
Hop-hop, I sorted every seat—
Top three carrots at the peak,
Rankings crisp as greens we seek.
One swift sort, no extra fuss,
Now charts align—bun-approved plus! 🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 72ca508 and d56a3f8.

📒 Files selected for processing (1)
  • mosu-app/src/pages/events/competition/index.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature#388

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@toothlessdev toothlessdev deleted the feature#388 branch September 8, 2025 17:18
@github-project-automation github-project-automation bot moved this to 완료 in mosu-client Sep 8, 2025
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Warnings
⚠️ PR에 Reviewers가 지정되어 있지 않습니다. 리뷰어를 지정해주세요.
Messages
📖 ✅ PR 제목에 이슈 번호가 포함되어 있습니다.
📖 ✅ PR에 라벨이 지정되어 있습니다.
📖 ✅ PR에 Assignees가 지정되어 있습니다.
📖 ✅ package.json에 변경사항이 없습니다.
📖 ✅ 브랜치 이름 'feature#388'이 컨벤션을 따릅니다.
📖 ✅ TypeScript 컴파일이 성공적으로 완료되었습니다.
📖 ✅ ESLint 검사 결과 문제가 없습니다.

📝 추가 및 변경된 파일

총 1개 파일 변경

└── 📂 mosu-app/
    └── 📂 src/
        └── 📂 pages/
            └── 📂 events/
                └── 📂 competition/
                    └── ⚛️ index.tsx

Generated by 🚫 dangerJS against d56a3f8

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

📚 Storybook이 Chromatic에 배포되었습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 완료

Development

Successfully merging this pull request may close these issues.

2 participants