Boolean operators #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for your contribution. It will take me a while to go through this. |
|
Any updates? I'm interested in having these operators |
Owner
|
Thanks for the reminder, I willl try to get to it soon. |
mdmunir
reviewed
Oct 11, 2018
| $this->associativity = self::RIGHT_ASSOC; | ||
| break; | ||
|
|
||
| case '=': |
There was a problem hiding this comment.
IMO, && should have higher precedence than || and || higher than =. Then =, >, < and other have same precedence.
So, A = B && C means A = (B && C)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some more code / test to make the library support boolean operators and comparison operators: !, &&, ||, =, <, <=, >, >=
These operators are required for one of my working library. However, I think it's also useful for everyone to support these operators