Draft
Conversation
TODO: everything.
Merged
pezcode
added a commit
to pezcode/magnum-plugins
that referenced
this pull request
Nov 24, 2021
Largely taken from mosra#91 Anything unrecognized is imported with the raw Assimp name and type. Can be turned off with ignoreUnrecognizedMaterialData, or overridden to import everything raw with forceRawMaterialData. The latter implies ignoreUnrecognizedMaterialData=false. For existing material tests we use ignoreUnrecognizedMaterialData, otherwise they'll break with every new Assimp version. TODO: tests, docs
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postponed from mosra/magnum#459, custom material attribute support offloaded to #116.
List of nightmares to wake up from, most of them hopefully obsoleted with the allegedly better PBR support in 5.1:
BaseColorgets imported asDiffuse, detect that (usingother attribs?importer name as in AssimpImporter: import animations #97) and fixUNKNOWN, detect that (usingother attribs?importer name as in AssimpImporter: import animations #97) and fix*TextureCoordinatesget imported as something else entirely for no reason, why?!Specular, with glossiness ignored, detect that and fix$mat.gltf.pbrSpecularGlossinessthing?MaterialTypeaccordingly (or are those present always for any glTF files? ffs)Current output from
magnum-sceneconverterfor an overview of how bad things are: