-
Notifications
You must be signed in to change notification settings - Fork 142
[MOSIP-44061] Update JDK 21 requirement in developer guide #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.2.0
Are you sure you want to change the base?
Conversation
WalkthroughUpdated JDK prerequisite text across ID Authentication Service developer guides to state support for "JDK 11 or JDK 21" instead of "JDK 11" only. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Updated the JDK requirement to include JDK 21. Signed-off-by: tarique-azeez <mdtarique2703@gmail.com>
Signed-off-by: tarique-azeez <mdtarique2703@gmail.com>
2d54814 to
16111e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/id-lifecycle-management/identity-verification/id-authentication-services/id-authentication-internal-service-developer-guide.md(1 hunks)docs/id-lifecycle-management/identity-verification/id-authentication-services/id-authentication-otp-service-developer-guide.md(1 hunks)docs/id-lifecycle-management/identity-verification/id-authentication-services/id-authentication-service-developer-guide.md(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/id-lifecycle-management/identity-verification/id-authentication-services/id-authentication-service-developer-guide.md
🔇 Additional comments (1)
docs/id-lifecycle-management/identity-verification/id-authentication-services/id-authentication-internal-service-developer-guide.md (1)
15-15: JDK prerequisite update is consistent and accurate.The change mirrors the update in the OTP Service guide, applying the same "JDK 11 OR JDK 21" prerequisite across the ID Authentication Internal Service documentation. The formatting is correct and aligns with the PR objective.
| Below are a list of tools required in ID Repository Services: | ||
|
|
||
| 1. JDK 11 | ||
| 1. JDK 11 OR JDK 21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify JDK requirement consistency across ID Authentication developer guides
# Search for JDK requirement mentions in ID Authentication guides
echo "=== JDK version mentions in ID Authentication guides ==="
fd -e md 'id-authentication.*developer-guide' docs/ --exec grep -n 'JDK' {} +
# Check for any remaining "JDK 11" mentions without JDK 21 in the same context
echo -e "\n=== Checking for unupdated 'JDK 11' mentions ==="
fd -e md 'id-authentication.*developer-guide' docs/ --exec grep -n 'JDK 11' {} + | grep -v 'JDK 21'
# List all id-authentication developer guide files
echo -e "\n=== All ID Authentication developer guide files ==="
fd -e md 'id-authentication.*developer-guide' docs/Repository: mosip/documentation
Length of output: 3312
JDK prerequisite update is correct, but inconsistencies exist across related guides.
The change to "JDK 11 OR JDK 21" in this file is accurate. However, the verification revealed:
-
Duplicate files not updated: The old documentation files at the root location (
docs/id-authentication-service-developer-guide.md,docs/id-authentication-internal-service-developer-guide.md,docs/id-authentication-otp-service-developer-guide.md) still reference only "JDK 11" and need to be updated to match. -
Capitalization inconsistency: The related guides in the new location use inconsistent capitalization—
id-authentication-service-developer-guide.mduses "JDK 11 or JDK 21" (lowercase), while the other two use "JDK 11 OR JDK 21" (uppercase). Standardize to uppercase "OR" across all three guides.
🤖 Prompt for AI Agents
docs/id-lifecycle-management/identity-verification/id-authentication-services/id-authentication-otp-service-developer-guide.md
lines 13-13: update the duplicate/outdated root docs and standardize
capitalization; open the three root files
docs/id-authentication-service-developer-guide.md,
docs/id-authentication-internal-service-developer-guide.md, and
docs/id-authentication-otp-service-developer-guide.md and change the JDK
prerequisite text to exactly "JDK 11 OR JDK 21" (uppercase OR) so all copies and
related guides match the new location wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide an overview of ID Authentication before start about services
Software setup should be JAVA 21 for 1.3.0 release branch. please update accordingly
Please replicated the structure provided with proper explanation
Updated the JDK requirement to include JDK 21.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.