Skip to content

Create NOTICE#239

Merged
Mahesh-Binayak merged 1 commit intomosip:developfrom
rajapandi1234:patch-16
Dec 24, 2025
Merged

Create NOTICE#239
Mahesh-Binayak merged 1 commit intomosip:developfrom
rajapandi1234:patch-16

Conversation

@rajapandi1234
Copy link
Contributor

@rajapandi1234 rajapandi1234 commented Dec 23, 2025

Summary by CodeRabbit

  • Chores
    • Added third-party attribution and license information documentation for included components.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

A new NOTICE file is added to the kernel-cbeffutil-api directory, documenting third-party attribution and license information for Apache-2.0 and other components. The file clarifies which license types require inclusion and references where full license texts are available.

Changes

Cohort / File(s) Summary
Third-party Attribution
kernel-cbeffutil-api/NOTICE
New NOTICE file with Apache-2.0 component attribution (Spring Boot, Jackson, Gson, Maven plugins). Specifies MPL-2.0, EPL, MIT, and BSD-3-Clause licenses do not require inclusion. References license texts in LICENSE and license/ directories.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A NOTICE hops in, so bright and true,
Giving thanks to licenses old and new,
Apache, Jackson, Spring in the spring,
With proper credits, our hearts do sing! 📜✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Create NOTICE' is generic and vague, lacking specificity about what the NOTICE document contains or its context within the project. Consider a more descriptive title such as 'Add NOTICE file with third-party attribution for kernel-cbeffutil-api' to clarify the purpose and scope of the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 464c7b1 and e9a6601.

📒 Files selected for processing (1)
  • kernel-cbeffutil-api/NOTICE
🔇 Additional comments (2)
kernel-cbeffutil-api/NOTICE (2)

48-54: LGTM!

The guidance on non-Apache licenses and reference to the license/ directory is clear and follows standard Apache compliance practices. This helps developers and auditors quickly understand which components require NOTICE attribution.


13-43: Clarify the scope and accuracy of the NOTICE file—it lists components not present as dependencies in kernel-cbeffutil-api.

The NOTICE file contains multiple inaccurate entries for this module: Spring Boot, OkHttp, imgscalr-lib, PowerMock, and Jackson Dataformat CSV are not dependencies; JNBIS, Hibernate Validator, and Commons Lang3 are only in biometrics-util. Verify whether this NOTICE is intended for the entire project or this module alone, then correct the listing to match kernel-cbeffutil-api's actual dependencies (kernel-core, kernel-biometrics-api, and their transitive dependencies: jackson-databind, gson, etc.).

Likely an incorrect or invalid review comment.

@Mahesh-Binayak Mahesh-Binayak merged commit 8c2796e into mosip:develop Dec 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants