Skip to content

Create THIRD-PARTY-NOTICES#235

Merged
Mahesh-Binayak merged 1 commit intomosip:developfrom
rajapandi1234:patch-12
Dec 24, 2025
Merged

Create THIRD-PARTY-NOTICES#235
Mahesh-Binayak merged 1 commit intomosip:developfrom
rajapandi1234:patch-12

Conversation

@rajapandi1234
Copy link
Contributor

@rajapandi1234 rajapandi1234 commented Dec 23, 2025

Summary by CodeRabbit

  • Documentation
    • Added comprehensive third-party license notices listing dependent packages, versions, licenses, and source information for compliance and transparency purposes.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: rajapandi1234 <138785181+rajapandi1234@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

A new THIRD-PARTY-NOTICES file is added to the kernel-cbeffutil-api directory, providing a centralized reference for third-party package licenses, versions, and homepage URLs. The file includes no functional code or logic—it is purely informational documentation.

Changes

Cohort / File(s) Summary
Third-party License Documentation
kernel-cbeffutil-api/THIRD-PARTY-NOTICES
File added to document licenses and version information for all third-party dependencies (MOSIP Kernel, Spring components, Jackson/Gson, testing libraries, Apache/Maven plugins, Jetty/OkHttp packages). Includes pointer to full license terms in the license directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A notice for all the folks kind and true,
Who gave us their code and their libraries too,
With licenses listed, both proper and clear,
We celebrate third-party gifts we hold dear! 📜✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding a new THIRD-PARTY-NOTICES file to document third-party package licenses.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 464c7b1 and bb256c4.

📒 Files selected for processing (1)
  • kernel-cbeffutil-api/THIRD-PARTY-NOTICES
🔇 Additional comments (3)
kernel-cbeffutil-api/THIRD-PARTY-NOTICES (3)

1-4: LGTM! Clear introduction.

The header and introduction appropriately set the context for the third-party license information.


127-139: No action needed. Both Protobuf Java versions listed are in active use across different modules: version 3.13.0 in test module and version 3.16.3 in biometrics-util module. The THIRD-PARTY-NOTICES file correctly reflects all dependencies used by the project.

Likely an incorrect or invalid review comment.


228-261: The THIRD-PARTY-NOTICES file accurately documents multiple Maven plugin versions in use across different modules. The root pom.xml declares maven-gpg-plugin version 1.5, while child modules (kernel-cbeffutil-api, kernel-biometrics-api, biometrics-util, kernel-biosdk-provider) reference properties that resolve to version 3.2.3. Similarly, maven-surefire-plugin versions 2.22.0 and 3.1.2 are used across different modules. This multi-version usage is expected in multi-module Maven projects and the documentation is correct.

@Mahesh-Binayak Mahesh-Binayak merged commit b8ef6bd into mosip:develop Dec 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants