feat(telemetry): add metrics to count the number of builds#23
Open
sylvain-reynaud wants to merge 1 commit intomainfrom
Open
feat(telemetry): add metrics to count the number of builds#23sylvain-reynaud wants to merge 1 commit intomainfrom
sylvain-reynaud wants to merge 1 commit intomainfrom
Conversation
thomasgouveia
requested changes
May 13, 2023
Member
thomasgouveia
left a comment
There was a problem hiding this comment.
Hi @sylvain-reynaud, thanks for the PR ! The idea is here, but you're wrong on the component.
registry and controller are two separated components. I've added in #13 the ability to the controller only to expose metrics. To work properly, you need to add a metrics server to the registry also. You can refer to this commit to learn how to do this.
Also, I prefer to have a dedicated package telemetry for each components. As we don't really know if the registry will be shipped with future release of Morty right now, It will be more easier to clean up files if we remove it.
To wrap up, what you need to change in your PR :
- Add a metrics server to the registry
- Add a
telemetrypackage into theregistryfolder (and the code in it for sure) - Update the configuration of the registry so we can pass a custom port for the metrics server
Feel free to ask questions if you need more details!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Ready to be reviewed !