Create a new flag to --exclude-columns from ripoff-export #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenson
reviewed
Aug 1, 2025
mortenson
reviewed
Aug 1, 2025
mortenson
reviewed
Aug 1, 2025
Comment on lines
+362
to
+365
| // Test 3: Combine both exclusion types | ||
| t.Run("Combined exclusions", func(t *testing.T) { | ||
| ripoffFile, err := ExportToRipoff(ctx, tx, []string{}, []string{"created_at", "users.email"}) | ||
| require.NoError(t, err) |
Owner
There was a problem hiding this comment.
I'm fine if the test only includes a combined case like this fwiw. But more tests == more good, probably
Contributor
Author
There was a problem hiding this comment.
I tend to have a lot more individual tests lately. I'm not sure if it's actually good, but having overlapping test edges tends to be more protective over the long term in my experience. Happy to prune it down to a more targeted system though if you'd prefer.
Owner
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #21 with a slightly different direction.
Pulling the motivation from that PR:
Generally, when using ripoff I tend to do the following:
ripoff-exportand do any manual tweaks that are needed.ripoff db/fake-datato reset to my known good state for development.One annoying thing (that this PR attempts to solve) is that I use
created_at/updated_attimestamps on every table in my database so eachripoff-exportinvocation touches every table definition in my saved dataset.--exclude-columnsallows you to specify eithertable.columnorcolumnthat should be excluded by name from every table. This lets you export a smaller set of data and prevents noise for DB-controlled columns like timestamps.