Skip to content

check whether the string is an arithmetic value before converting it. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DapengFeng wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check whether the string is an arithmetic value before converting it. #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cc0819
check whether the string is an arithmetic value before converting it.
DapengFeng Oct 29, 2024
c7a1424
fix type traits check of bool
DapengFeng Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion include/argparse/argparse.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <type_traits> // for declval, false_type, true_type, is_enum
#include <utility> // for move, pair
#include <vector> // for vector
#include <regex> // for regex, regex_match

#if __has_include(<magic_enum.hpp>)
#include <magic_enum.hpp> // for enum_entries
Expand Down Expand Up @@ -163,6 +164,12 @@ namespace argparse {
explicit ConvertType(const T &value) : ConvertBase(), data(value) {};

void convert(const std::string &v) override {
if constexpr (std::is_arithmetic_v<T> && !std::is_same_v<T, bool>) {
// check if the string is an arithmetic value
if (!std::regex_match(v, std::regex(("((\\+|-)?[[:digit:]]+)(\\.(([[:digit:]]+)?))?")))) {
throw std::invalid_argument("Invalid argument, could not convert \"" + v + "\" to " + typeid(T).name());
}
}
data = get<T>(v);
}

Expand Down Expand Up @@ -454,7 +461,7 @@ namespace argparse {
program_name = std::filesystem::path(argv[0]).stem().string();
params = std::vector<std::string>(argv + 1, argv + argc);

bool& _help = flag("?,help", "print help");
bool& _help = flag("h,help", "print help");

auto is_value = [&](const size_t &i) -> bool {
return params.size() > i && (params[i][0] != '-' || (params[i].size() > 1 && std::isdigit(params[i][1]))); // check for number to not accidentally mark negative numbers as non-parameter
Expand Down