This repository was archived by the owner on May 14, 2024. It is now read-only.
Bug: calling appear() on multiple DOM elements #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculation. The reason was, that $prior_appeared did not persist correctly on case appear() was called on more that one selector. Simply fixed by making $prior_appeared's to persist by pushing them instead of setting them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case appear() is called on multiple DOM elements, $prior_appeared did not remember the prior appeared elements for ALL selectors. Thus $disappeared was calculated incorrectly which caused weird behaviour. Fixed by simply pushing prior appeared elements into $prior_appeared, instead resetting $prior_appeared for every selector / jquery element.