Update for Titanium SDK 6.0.0, bugfix, and README info about NDK r11#57
Open
cr0ybot wants to merge 2 commits intomorinel:masterfrom
Open
Update for Titanium SDK 6.0.0, bugfix, and README info about NDK r11#57cr0ybot wants to merge 2 commits intomorinel:masterfrom
cr0ybot wants to merge 2 commits intomorinel:masterfrom
Conversation
After building for SDK 6.0.0, an error was occurring in onMessage for using startsWith() on a null object, so I’m checking for null first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know there's already another pending pull request for an update to SDK 6, but using that build was crashing my app every time a notification was received. So I fixed that with a check for null when a message is received... but then I was unable to build the module myself. I found out that SDK 6 currently only supports Android NDK r11. That worked, so I updated the README.