Skip to content

Conversation

@kixelated
Copy link
Collaborator

If it's not implemented... don't implement it...

#135

If it's not implemented... don't implement it...
@kixelated kixelated changed the title Remove with_unreliable. Remove with_unreliable for non-WASM. Dec 17, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Walkthrough

The PR removes the with_unreliable(self, val: bool) -> Self builder method from ClientBuilder across three locations: web-transport-quinn/src/client.rs, web-transport/src/quinn.rs, and web-transport/src/wasm.rs. In web-transport-quinn, the method enforced val == true with a panic; in the other implementations, it delegated to an inner builder. The removals reduce the public API surface of ClientBuilder and eliminate the associated runtime checks and delegation logic.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description 'If it's not implemented... don't implement it...' is vague and generic, using non-specific phrasing that doesn't clearly convey what the changeset accomplishes. Enhance the description with specific details about why with_unreliable is being removed and what issue #135 addresses.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove with_unreliable for non-WASM' clearly and specifically describes the main change: removing the with_unreliable method from non-WASM implementations while keeping it in WASM.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch no-panic

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2305b8e and 85a5675.

📒 Files selected for processing (3)
  • web-transport-quinn/src/client.rs (0 hunks)
  • web-transport/src/quinn.rs (0 hunks)
  • web-transport/src/wasm.rs (0 hunks)
💤 Files with no reviewable changes (3)
  • web-transport-quinn/src/client.rs
  • web-transport/src/quinn.rs
  • web-transport/src/wasm.rs

Comment @coderabbitai help to get the list of available commands and usage tips.

@kixelated kixelated merged commit a2db253 into main Dec 24, 2025
1 check passed
@kixelated kixelated deleted the no-panic branch December 24, 2025 04:55
@github-actions github-actions bot mentioned this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants