Merged
Conversation
evgeny-s
added
A8-mergeoncegreen
tmpolaczyk
reviewed
Apr 24, 2025
Contributor
WASM runtime size check:Compared to target branchdancebox runtime: 1528 KB (no changes) ✅ flashbox runtime: 888 KB (no changes) ✅ dancelight runtime: 2332 KB (no changes) ✅ container chain template simple runtime: 1168 KB (no changes) ✅ container chain template frontier runtime: 1456 KB (no changes) ✅ |
Co-authored-by: tmpolaczyk <44604217+tmpolaczyk@users.noreply.github.com>
Contributor
Coverage Report@@ Coverage Diff @@
## master MD-922-evgeny-storage-growth-ratio +/- ##
======================================================================
- Coverage 64.76% 64.75% -0.01%
Files 482 482
+ Lines 78171 78229 +58
======================================================================
+ Hits 50621 50657 +36
+ Misses 27550 27572 +22
|
Agusrodri
reviewed
Apr 28, 2025
tmpolaczyk
approved these changes
Apr 29, 2025
Agusrodri
approved these changes
Apr 29, 2025
…io' into MD-922-evgeny-storage-growth-ratio
…io' into MD-922-evgeny-storage-growth-ratio
tmpolaczyk
reviewed
May 5, 2025
# Conflicts: # Cargo.lock
nanocryk
pushed a commit
that referenced
this pull request
May 19, 2025
Co-authored-by: tmpolaczyk <44604217+tmpolaczyk@users.noreply.github.com>
evgeny-s
added
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Apply
GasLimitStorageGrowthRatioparameter.Initially introduced here.
Observations:
After the storage ratio parameter is enabled, the gas limit for some tests should be increased manually.
Theoretically, we want the
eth_estimateGasshould be able to estimate it automatically.Before merge:
tanssi-polkadot-stable2412