Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=========================================
Coverage 88.25% 88.25%
+ Complexity 739 737 -2
=========================================
Files 76 76
Lines 2274 2274
=========================================
Hits 2007 2007
Misses 267 267 ☔ View full report in Codecov by Sentry. |
kabalin
changed the title
martignoni
added a commit
to moodlebox/moodle-tool_moodlebox
that referenced
this pull request
Aug 11, 2024
MakinZeel
pushed a commit
to SE-Stuttgart/moodle-block_booksearch
that referenced
this pull request
Aug 12, 2024
…we swap to temporary workaround (moodlehq/moodle-plugin-ci#310)
kabalin
changed the title
This is to have control over image supplied version to prevent regression similar to moodlehq#309.
Member
Author
|
I suggest to install 0.39.7 explicitly as part of initialisation step, so we have control over the version we use. Also |
JayBraker
added a commit
to rwthmoodle/moodle-mod_pdfannotator
that referenced
this pull request
Aug 22, 2024
Member
Author
|
Closing in favour of #312 |
JayBraker
added a commit
to rwthmoodle/moodle-mod_pdfannotator
that referenced
this pull request
Aug 22, 2024
* Fix Syntax for moodle-plugin-ci: Provide path to plugin source as last argument * Temporary fix for CI moodlehq/moodle-plugin-ci#310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround for #309. Not sure if we need to make it permanent and advice changing workflows, depends on how quickly the issue will be fixed upstream.