DataTrigger does not respect serializable attribute

data/service/data-trigger.js

@@ -483,7 +483,7 @@ Object.defineProperties(exports.DataTrigger, /** @lends DataTrigger */ {
             trigger._objectPrototype = prototype;
             trigger._propertyName = name;
             trigger._isGlobal = propertyDescriptor.isGlobal;
-            if(!serviceTriggers) {
+            if (!serviceTriggers) {
                 serviceTriggers = {};
                 service._dataObjectTriggers.set(objectDescriptor,serviceTriggers);
             }
@@ -494,6 +494,7 @@ Object.defineProperties(exports.DataTrigger, /** @lends DataTrigger */ {
     _addTrigger: {
         value: function (service, objectDescriptor, prototype, name) {
             var descriptor = objectDescriptor.propertyDescriptorForName(name),
+                serializable = Montage.getPropertyAttribute(prototype, name, "serializable"),
                 trigger;
             if (descriptor) {
                 trigger = Object.create(this._getTriggerPrototype(service));
@@ -512,7 +513,8 @@ Object.defineProperties(exports.DataTrigger, /** @lends DataTrigger */ {
                         set: function (value) {
                             trigger._setValue(this, value);
                             // (trigger||(trigger = DataTrigger._createTrigger(service, objectDescriptor, prototype, name,descriptor)))._setValue(this, value);
-                        }
+                        },
+                        serializable: serializable
                     });
                 } else {
                     Montage.defineProperty(prototype, name, {
@@ -523,7 +525,8 @@ Object.defineProperties(exports.DataTrigger, /** @lends DataTrigger */ {
                         set: function (value) {
                             trigger._setValue(this, value);
                             // (trigger||(trigger = DataTrigger._createTrigger(service, objectDescriptor, prototype, name,descriptor)))._setValue(this, value);
-                        }
+                        },
+                        serializable: serializable
                     });
                 }
             }

test/spec/data/data-trigger.js

@@ -0,0 +1,145 @@
+var DataTrigger = require("montage/data/service/data-trigger").DataTrigger,
+    DataService = require("montage/data/service/data-service").DataService,
+    Montage = require("montage").Montage,
+    ObjectDescriptor = require("montage/core/meta/object-descriptor").ObjectDescriptor,
+    PropertyDescriptor = require("montage/core/meta/property-descriptor").PropertyDescriptor;
+
+
+
+var ModelObject = Montage.specialize({
+    // Only ancestors, favoriteAunts, & siblings should be serializable.
+    // Each property has a comment explaining why it is or is not serializable.
+
+    //Serializable (has get & set)
+    ancestors: {
+        get: function () {
+            if (!this._ancestors) {
+                this._ancestors = [];
+            }
+            return this._ancestors;
+        },
+        set: function (value) {
+            this._ancestors = value;
+        }
+    },
+
+    //NOT Serializable (serializable attribute is false)
+    children: {
+        get: function () {
+            if (!this._children) {
+                this._children = [];
+            }
+            return this._children;
+        },
+        set: function (value) {
+            this._ancestors = value;
+        },
+        serializable: false
+    },
+
+    //Serializable
+    siblings: {
+        value: undefined
+    },
+
+    //NOT Serializable (not writable)
+    cousins: {
+        value: undefined,
+        writable: false
+    },
+
+    //NOT Serializable (serializable attribute is false)
+    friends: {
+        value: undefined,
+        serializable: false
+    },
+
+
+
+    //NOT Serializable (not writable)
+    aunts: {
+        get: function () {
+            if (!this._aunts) {
+                this._aunts = [];
+            }
+            return this._aunts;
+        }
+    },
+
+    //NOT Serializable (not writable & serializable attribute is false)
+    uncles: {
+        get: function () {
+            if (!this._uncles) {
+                this._uncles = [];
+            }
+            return this._uncles;
+        },
+        serializable: false
+    },
+
+
+    /** 
+     * Derived Properties
+     */
+    //Serializable
+    favoriteAunts: {
+        value: undefined
+    },
+
+    //NOT Serializable (serializable attribute is false)
+    favoriteUncles: {
+        value: undefined,
+        serializable: false
+    }
+});
+
+var ModelDescriptor = new ObjectDescriptor().initWithName("ModelObject"),
+    derived;
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("ancestors", ModelDescriptor, Infinity));
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("children", ModelDescriptor, Infinity));
+
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("siblings", ModelDescriptor, Infinity));
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("cousins", ModelDescriptor, Infinity));
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("friends", ModelDescriptor, Infinity));
+
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("aunts", ModelDescriptor, Infinity));
+ModelDescriptor.addPropertyDescriptor(new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("uncles", ModelDescriptor, Infinity));
+
+derived = new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("favoriteAunts", ModelDescriptor, Infinity);
+derived.definition = "aunts.filter{ isFavorite }";
+ModelDescriptor.addPropertyDescriptor(derived);
+
+derived = new PropertyDescriptor().initWithNameObjectDescriptorAndCardinality("favoriteUncles", ModelDescriptor, Infinity);
+derived.definition = "uncles.filter{ isFavorite }";
+ModelDescriptor.addPropertyDescriptor(derived);
+
+describe("A DataTrigger", function() {
+
+    it("can respect serializable property", function () {
+        // Mimics DataService#_prototypeForType
+        var prototype = Object.create(ModelObject.prototype),
+            requisites = new Set(),
+            service = new DataService(),
+            cleanObjectCreateInstance, cleanObjectCreatePropertyNames,
+            cleanConstructorInstance, cleanConstructorInstancePropertyNames,
+            triggerInstance, triggerPropertyNames,
+            propertyNames;
+
+        DataTrigger.addTriggers(service, ModelDescriptor, prototype, requisites);
+
+
+        cleanConstructorInstance = new ModelObject();
+        cleanConstructorInstancePropertyNames = Montage.getSerializablePropertyNames(cleanConstructorInstance);        
+
+        cleanObjectCreateInstance = Object.create(ModelObject.prototype);
+        cleanObjectCreatePropertyNames = Montage.getSerializablePropertyNames(cleanObjectCreateInstance); 
+
+        triggerInstance = Object.create(prototype);
+        triggerPropertyNames = Montage.getSerializablePropertyNames(triggerInstance);
+
+        expect(triggerPropertyNames).toEqual(["ancestors", "siblings", "favoriteAunts", "identifier"]);
+        expect(triggerPropertyNames).toEqual(cleanObjectCreatePropertyNames);
+        expect(cleanObjectCreatePropertyNames).toEqual(cleanConstructorInstancePropertyNames);
+    });
+
+});