Minimal test case for super() bug in MontageReviver #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+100 points to @aadsm for this discovery: a bug caused by a strange loop!
The problem
MontageReviveris a subclass ofReviver. When you callMontageReviver#reviveRootObjectit callssuper, which resolves toReviver#reviveRootObject. That method then calls other methods on the object, which eventually wind their way around to callingMontageReviver#reviveRootObjectagain. When we reach thesupercall the second time, which is still nested inside the call stack for the first time, the super context thinks we're trying to call the parent ofReviver, rather than ofMontageReviver, and is thus a no-op.Possible fixes
Reviver.prototype.reviveRootObjectinstead of having the convenience ofsuperin this specific case.superto work in cases like this. When we call super() from inside Class#method, we could wrap Class#method in a decorator. Then if it is called again within itself, the wrapper resets the super context just for the duration of the inner call.