fix: support IP address as QBITTORRENT_HOST#86
Merged
monstermuffin merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
aiohttp rejects session cookies by default when the host is an IP literal. Detect whether QBITTORRENT_HOST is an IP address at startup and, if so, create the ClientSession with CookieJar(unsafe=True). Hostname-based connections are unaffected. Made-with: Cursor
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
QBITTORRENT_HOSTis set to a raw IP address,aiohttpdrops thesession cookie after login, causing all subsequent requests to return
403.
The fix detects whether
QBITTORRENT_HOSTis an IP address at startupand passes
CookieJar(unsafe=True)to theClientSessionin that case.Tested locally in Docker against linuxserver/qbittorrent:latest.
Hostname (gluetun) - no regression:
unsafe False
Successfully logged in to qBittorrent
current_port 6881
IP - before fix:
login False 200 Ok.
cookies False
prefs False 403 Forbidden
IP - after fix:
unsafe True
Successfully logged in to qBittorrent
current_port 6881