fix(configure_snapraid): patch snapraid-btrfs before install and improve idempotency#137
Open
adamantike wants to merge 1 commit intomonstermuffin:mainfrom
Open
Conversation
…ove idempotency Apply the `snapraid-btrfs` upstream patch (workaround for the mentioned unmerged PR) directly to the cloned source before copying, rather than patching the installed binary afterwards. This avoids always marking the Ansible task as changed due to the patch, and ensures the copy step only distributes the already-patched version, improving idempotency. Also, add `force: true` to the git clone step so local modifications don't block updates, and track actual repo changes via before/after commit hashes to avoid false change reports. Lastly, remove the redundant `chmod` task since the copy step already sets the correct mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the
snapraid-btrfsupstream patch (workaround for the mentioned unmerged PR) directly to the cloned source before copying, rather than patching the installed binary afterwards. This avoids always marking the Ansible task as changed due to the patch, and ensures the copy step only distributes the already-patched version, improving idempotency.Also, add
force: trueto the git clone step so local modifications don't block updates, and track actual repo changes via before/after commit hashes to avoid false change reports.Lastly, remove the redundant
chmodtask since the copy step already sets the correct mode.