fix(install_snapraid): use regex_search for version extraction#136
Open
adamantike wants to merge 1 commit intomonstermuffin:mainfrom
Open
fix(install_snapraid): use regex_search for version extraction#136adamantike wants to merge 1 commit intomonstermuffin:mainfrom
adamantike wants to merge 1 commit intomonstermuffin:mainfrom
Conversation
SnapRAID v14 changed its `--version` output: - Before: `SnapRAID v13.0 by Andrea Mazzoleni, https://www.snapraid.it` - After: `SnapRAID CLI v14.1 by Andrea Mazzoleni, https://www.snapraid.it` This breaks the current approach of using `split()[1]` to extract the version number. Replace with `regex_search` using `v?(\d[\d.]*)` to locate the version token regardless of position, while remaining compatible with older output formats and version strings without a "v" prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnapRAID v14 changed its
--versionoutput:SnapRAID v13.0 by Andrea Mazzoleni, https://www.snapraid.itSnapRAID CLI v14.1 by Andrea Mazzoleni, https://www.snapraid.itThis breaks the current approach of using
split()[1]to extract the version number.Replace with
regex_searchusingv?(\d[\d.]*)to locate the version token regardless of position, while remaining compatible with older output formats and version strings without a "v" prefix.