Skip to content
This repository was archived by the owner on Aug 8, 2024. It is now read-only.

Conversation

@migueldeicaza
Copy link
Contributor

These are the patches that I did last year, but they were against the Xamarin/BockBuild fork which was the old, proprietary one, and not the open source one.

info('cmd: %s' % ' '.join(sys.argv))

progress ('here')
if len (sys.argv) < 2:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug printf.


global active_profile
progress (sys.argv[1])
Package.profile = active_profile = self.load_profile (sys.argv[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many other places.

package.local_ld_flags = ['-arch i386', '-arch x86_64']
package.local_gcc_flags = ['-arch i386', '-arch x86_64']
if arch == 'darwin-arm64':
package.local_ld_flags = ['-arch arm64']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation.

package.local_ld_flags = ['-arch arm64', '-arch x86_64']
package.local_gcc_flags = ['-arch arm64', '-arch x86_64']
elif arch == 'darwin-32':
package.local_ld_flags = ['-arch i386', '-m32']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the darwin-32 block ?


def process(self, path):
run_shell('dsymutil -t 2 "%s" >/dev/null' % path)
run_shell('dsymutil "%s" >/dev/null' % path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed ?


def arch_build(self, arch):
if arch == 'darwin-universal':
self.local_ld_flags = ['-arch i386', '-arch x86_64']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still care for 32 bit ?

'patches/gtk/0078-Optimize-querying-symbolic-hotkeys.patch',
'patches/gtk/gdk-quartz-Remove-titlebar-handling-from-find_child.patch'
'patches/gtk/gdk-quartz-Remove-titlebar-handling-from-find_child.patch',
'patches/gtk/bigsurfix.patch'
Copy link
Contributor

@vargaz vargaz Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps newer versions don't need this (or other) patches ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants