Fix model transformation, orientation and tangent generation#113
Open
RaYRoD-TV wants to merge 6 commits intomonkeyman192:pathfinderfrom
Open
Fix model transformation, orientation and tangent generation#113RaYRoD-TV wants to merge 6 commits intomonkeyman192:pathfinderfrom
RaYRoD-TV wants to merge 6 commits intomonkeyman192:pathfinderfrom
Conversation
- Coordinate System Fix: Properly transformed between Blender's Z-up and No Man's Sky's Y-up coordinate systems - Vertex Processing: Enhanced handling of vertices, normals, and tangents for correct orientation - Smooth Shading: Improved normal averaging for shared vertices - Vector Dimension Fix: Corrected the tangent calculation to use 3D vectors during processing and only convert to 4D at the end - Tangent Vector Dimension Fix: Fixed dimension mismatch by: Using 3D vectors during calculation instead of 4D Only converting to 4D vectors (w=1.0) at the end - Transformation Matrix: Improved transformation matrix calculations for consistent model positioning and rotation - Model Orientation: Fixed upside-down and incorrectly rotated models in-game
monkeyman192
reviewed
Apr 1, 2025
addon_script.py
Outdated
|
|
||
| return tangents | ||
|
|
||
| # FIXED: Improved transform application function for better orientation |
Owner
There was a problem hiding this comment.
this function has no fixes to it?
monkeyman192
reviewed
Apr 1, 2025
| return AnimationFiles | ||
|
|
||
| #Main Mesh parser - Fixed to eliminate faceting | ||
| # FIXED: Fixed mesh parser for proper orientation and smoothing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.