You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The gem doesn't know anything about Rails AFAIK, but what breaks with an older version? Any way to write a test that shows it and run tests with older versions of rails?
Yes the gem doesn't explicitly depend on Rails, but if I'm not mistaken, mb_chars exists only in ActiveSupport, so in reality it is a (undeclared) dependency.
Just checked that the next method in the call chain - unicode_normalize seems to exist since about Ruby 2.2, so either it's not really worth checking anything, or to make it super safe, the check could be something along: text.to_s.respond_to?(:unicode_normalize) ? text.to_s.unicode_normalize : text.to_s.mb_chars.unicode_normalize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated call of
mb_chars.Not sure if we should check the Rails version to ensure this gem still works with older versions?