Skip to content

DRIVERS-3380 Filter deprioritized candidates by address only #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prestonvasquez merged 1 commit into from
Jan 28, 2026
Merged

DRIVERS-3380 Filter deprioritized candidates by address only #1886

prestonvasquez merged 1 commit into from
Jan 28, 2026

Conversation

@prestonvasquez
Copy link
Member

@prestonvasquez prestonvasquez commented Jan 26, 2026 •
edited
Loading

DRIVERS-3380

Test scenario:

  1. Op to primary b:27017
  2. Op fails
  3. Driver adds b:27017 as RSPrimary to deprioritized list
  4. Meanwhile, b:27017 loses election, steps down to RSSecondary
  5. Retry happens, should still avoid b:27017

Please complete the following before merging:

  • Is the relevant DRIVERS ticket in the PR title?

@prestonvasquez prestonvasquez requested a review from a team as a code owner January 26, 2026 21:40
@prestonvasquez prestonvasquez requested review from NoahStapp and vector-of-bool and removed request for a team January 26, 2026 21:40
baileympearson
baileympearson approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing in Node: https://parsley.corp.mongodb.com/evergreen/mongo_node_driver_next_lint_run_unit_tests_node_20.19.0_patch_840c77bb76f60d22e271e2e8775898d7472c61cf_697a30efd9b2a60007413f08_26_01_28_15_53_28/0/task?bookmarks=0%2C341&selectedLineRange=L197&shareLine=197

Thanks @prestonvasquez !

@prestonvasquez prestonvasquez merged commit 9e2acc6 into mongodb:master Jan 28, 2026
6 checks passed
@prestonvasquez prestonvasquez deleted the improvement/drivers3880-add-ust-for-deprioritized-nearest-state-change branch January 28, 2026 17:27
vector-of-bool
vector-of-bool approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vector-of-bool vector-of-bool vector-of-bool approved these changes

@baileympearson baileympearson baileympearson approved these changes

@NoahStapp NoahStapp NoahStapp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prestonvasquez @vector-of-bool @baileympearson @NoahStapp