Skip to content

Conversation

@fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Apr 28, 2023

Proposed changes

Add commands atlas datalakepipelines availablesnaphosts and availableschedules

Jira ticket: CLOUDP-171854

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@fmenezes fmenezes marked this pull request as ready for review April 28, 2023 14:37
@fmenezes fmenezes requested a review from a team as a code owner April 28, 2023 14:37
@fmenezes fmenezes requested a review from a team April 28, 2023 14:37
gssbzn
gssbzn previously approved these changes Apr 28, 2023
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM comments are not blocking

Co-authored-by: Gustavo Bazan <gustavo.bazan@mongodb.com>
gssbzn
gssbzn previously approved these changes Apr 28, 2023
Copy link
Contributor

@sarahsimpers sarahsimpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, thanks!

- command_path: atlas dataLakePipelines availableSchedules
package_name: availableschedules
description: Available Schedules for data lake pipelines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Available Schedules for data lake pipelines.
description: Return all available schedules for the specified data lake pipeline.

package_name: availableschedules
store_name: PipelineAvailableSchedulesLister
store_method: PipelineAvailableSchedules
description: Returns all available schedules for the data lake pipelines for your project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Returns all available schedules for the data lake pipelines for your project.
description: Return all available schedules for the specified data lake pipeline.

package_name: availablesnapshots
store_name: PipelineAvailableSnapshotsLister
store_method: PipelineAvailableSnapshots
description: Returns all available backup snaphots for the data lake pipelines for your project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Returns all available backup snaphots for the data lake pipelines for your project.
description: Return all available backup snapshots for the specified data lake pipeline.

atlas dataLakePipelines availableSchedules list Pipeline1
- command_path: atlas dataLakePipelines availableSnapshots
package_name: availablesnapshots
description: Available backup snapshots for data lake pipelines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Available backup snapshots for data lake pipelines.
description: Return all available backup snapshots for the specified data lake pipeline.

Copy link
Contributor

@sarahsimpers sarahsimpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmenezes fmenezes merged commit dbef1e3 into master May 4, 2023
@fmenezes fmenezes deleted the CLOUDP-171854 branch May 4, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants