Skip to content

Fix MongoStore increment behavior for expired cache entries #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zigzagdev wants to merge 2 commits into
base: 5.x
Choose a base branch
from
+12 −6
Open

Fix MongoStore increment behavior for expired cache entries #3467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5beb0b7
fix MongoStore:: increment to ignore expired cache entries
zigzagdev Dec 15, 2025
d0c00a2
add: regression test for increment method about expired cache
zigzagdev Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/Cache/MongoStore.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,18 @@ public function get($key): mixed
#[Override]
public function increment($key, $value = 1): int|float|false
{
$now = $this->getUTCDateTime();

$result = $this->collection->findOneAndUpdate(
[
'_id' => $this->prefix . $key,
'expires_at' => ['$gt' => $now],
],
[
'$inc' => ['value' => $value],
],
[
'projection' => ['value' => 1, 'expires_at' => 1],
'returnDocument' => FindOneAndUpdate::RETURN_DOCUMENT_AFTER,
],
);
Expand All @@ -198,12 +202,6 @@ public function increment($key, $value = 1): int|float|false
return false;
}

if ($result['expires_at'] <= $this->getUTCDateTime()) {
$this->forgetIfExpired($key);

return false;
}

return $result['value'];
}

Expand Down
8 changes: 8 additions & 0 deletions tests/Cache/MongoCacheStoreTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,14 @@

$this->insertToCacheTable('foo', 10, -5);
$this->assertFalse($store->increment('foo', 5));

$doc = DB::connection('mongodb')
->getCollection($this->getCacheCollectionName())
->findOne(
['_id' => $this->withCachePrefix('foo')],
['projection' => ['value' => 1]]

Check failure on line 207 in tests/Cache/MongoCacheStoreTest.php

View workflow job for this annotation

GitHub Actions / phpcs 

Multi-line function calls must have a trailing comma after the last parameter.
);
$this->assertSame(10, $doc['value']);
}

public function testTTLIndex()
Expand Down
Loading