DOP-5440: Ignore github_username when using persistence module #1090
Conversation
|
Your feature branch infrastructure has been deployed! Your webhook URL is: https://8ext2l4ca9.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
mmeigs
left a comment
mmeigs
left a comment
There was a problem hiding this comment.
Just a couple nits. Also, I thought the persistence module was now solely in netlify extensions? I didn't know this code was still in use...
modules/persistence/index.ts
Outdated
| // Safely convert jobId in case of empty string | ||
| const autobuilderJobId = jobId || undefined; | ||
| const autobuilderJobId = jobId; |
There was a problem hiding this comment.
Should we remove the comment now? Or should we keep the fallback to keep the comment true?
There was a problem hiding this comment.
Good point! I ended up just removing autobuilderJobId altogether since it's redundant with jobId being inherently of string | undefined type anyways
|
|
||
| describe('metadataFromZip', () => { | ||
| it('should get metadata from site.bson', async () => { | ||
| const githubUser = 'gritty'; |
There was a problem hiding this comment.
I believe we can remove GH_USER constant
Yup, the extensions download the code from this repo and use it. We can probably move the persistence module logic directly into the extensions in the future |
Stories/Links:
DOP-5440
Related PRs:
Notes
github_usernamewhen upserting build artifacts through the persistence module.updated_documentscollection no longer has duplicatedpage_ids.README updates