refactor: change string method name to text#5
Open
mt-kelvintaywl wants to merge 1 commit intomoneytree:masterfrom
Open
refactor: change string method name to text#5mt-kelvintaywl wants to merge 1 commit intomoneytree:masterfrom
string method name to text#5mt-kelvintaywl wants to merge 1 commit intomoneytree:masterfrom
Conversation
|
I added a minimum protection to avoid merging without approvals. |
m13
approved these changes
Jan 12, 2020
There was a problem hiding this comment.
But I prefer @mt-ronkorving approving it
Ups! This is my personal account.
Collaborator
|
I'm gonna let this sit here for a while if you don't mind. Need to think about this in the bigger picture of the library (there is one ;)). See also #4 |
Author
|
SGTM :) i understand the motivations for #4 as well 👍 looking forward to the developments of this library 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
just a thought, but
I was just thinking perhaps
textas a method name would be more 'human' / layman ! :)since it'd now be
text, domain, email🤓