Subtitle settings on playback screen #652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasky
force-pushed
the
osd-settings-subtitles
branch
2 times, most recently
from
7686e71 to
e9e1e5f
Compare
wasky
force-pushed
the
osd-settings-subtitles
branch
from
e9e1e5f to
4859806
Compare
wasky
force-pushed
the
osd-settings-subtitles
branch
from
4859806 to
a118925
Compare
wasky
force-pushed
the
osd-settings-subtitles
branch
from
a118925 to
f9f131f
Compare
Author
|
@moneytoo Could you please look into this PR? It's a bit time consuming for me to rebase on top of master and resolve conflicts when master branch is changing. |
wasky
force-pushed
the
osd-settings-subtitles
branch
from
f9f131f to
673d7c4
Compare
New subtitle settings on the playback screen allow to adjust parameters like position, size, edge type, and typeface. To access these settings, long-press the subtitle icon on the playback screen.
This commit removes subtitles settings from settings screen and adds info that subtitles settings are available during video playback by long pressing the subtitle icon.
The commit that introduced the OSD subtitles settings screen changed the logic responsible for setting subtitles size. The previous logic included a workaround for a bug causing large subtitles in landscape mode. The workaround has also been removed along with the previous logic. This commit fixes the bug, ensuring subtitles have the exact same size in both portrait and landscape modes.
wasky
force-pushed
the
osd-settings-subtitles
branch
from
673d7c4 to
8b4048c
Compare
|
@moneytoo please consider this PR. It is very useful but not too obtrusive. |
Author
|
@Pentaphon The author of this project has not responded to this pull request for over 10 months. For that reason, I created a modified version of the app with this feature and other additional enhancements. You can download it here. |
|
@wasky Any possibility to open issues or at least discussions on your fork repo? |
Author
|
@Bec-de-Xorbin I enabled issues and discussions. You can try now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the subtitle settings feature to the playback screen. This pull request resolves #651. Also resolves #301.
For better readability, the pull request is split into multiple commits: