Skip to content

Conversation

@haruki-yamanashi
Copy link
Contributor

Change default value of DELEGATE_AUTHORIZED_ROLES from admin to
monitoring-delegate because of following two reasons.

  • There is inconsistency between monasca-docker default value and
    OpenStack monasca api project document.
  • It's not secure to allow admin authorization to other users.

@haruki-yamanashi
Copy link
Contributor Author

@haruki-yamanashi haruki-yamanashi force-pushed the delegate-authorized-roles branch from be9d6d0 to 88c254b Compare November 28, 2017 09:52
@knakazono
Copy link
Contributor

@matrixik
Copy link
Member

matrixik commented Dec 4, 2017

Don't you also need to change it in Keystone?

@witekest
Copy link
Member

witekest commented Dec 4, 2017

@matrixik But only in OpenStack's Keystone. The only scenario when delegate roles are used, is libvirt monitoring.

@matrixik
Copy link
Member

matrixik commented Dec 5, 2017

Every time same tempest test fail:

test_list_metrics_with_project


==============================
Failed 1 tests - output below:
==============================

monasca_tempest_tests.tests.api.test_metrics.TestMetrics.test_list_metrics_with_project[gate]
---------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):
      File "monasca_tempest_tests/tests/api/test_metrics.py", line 505, in test_list_metrics_with_project
        if str(element['name']) == name:
    UnicodeEncodeError: 'ascii' codec can't encode characters in position 8-11: ordinal not in range(128)
    

Captured pythonlogging:
~~~~~~~~~~~~~~~~~~~~~~~
    2017-12-05 13:51:22,461 13 INFO     [tempest.lib.common.rest_client] Request (TestMetrics:test_list_metrics_with_project): 201 POST http://keystone:35357/v3/projects 0.049s
    2017-12-05 13:51:22,477 13 INFO     [tempest.lib.common.rest_client] Request (TestMetrics:test_list_metrics_with_project): 204 POST http://monasca:8070/v2.0/metrics?tenant_id=df4a550a8a684b0095c598dfa531f565 0.014s
    2017-12-05 13:51:22,498 13 INFO     [tempest.lib.common.rest_client] Request (TestMetrics:test_list_metrics_with_project): 200 GET http://monasca:8070/v2.0/metrics?tenant_id=df4a550a8a684b0095c598dfa531f565 0.015s
    2017-12-05 13:51:22,599 13 INFO     [tempest.lib.common.rest_client] Request (TestMetrics:_run_cleanups): 204 DELETE http://keystone:35357/v3/projects/df4a550a8a684b0095c598dfa531f565 0.096s

Change default value of DELEGATE_AUTHORIZED_ROLES from `admin` to
`monitoring-delegate` because of following two reasons.
- There is inconsistency between monasca-docker default value and
OpenStack monasca agent project document.
- It's not secure to allow admin authorization to other users.
@haruki-yamanashi haruki-yamanashi force-pushed the delegate-authorized-roles branch from 63a109c to 16db182 Compare December 7, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants