Skip to content

fix: improve submolt lookup to handle edge cases #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erkinalp wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve submolt lookup to handle edge cases #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/services/SubmoltService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,27 @@ class SubmoltService {
* @returns {Promise<Object>} Submolt
*/
static async findByName(name, agentId = null) {
const normalizedName = name.toLowerCase().trim();

// First, check if the submolt exists with a simple query
const submolt = await queryOne(
`SELECT s.*,
(SELECT role FROM submolt_moderators WHERE submolt_id = s.id AND agent_id = $2) as your_role
FROM submolts s
WHERE s.name = $1`,
[name.toLowerCase(), agentId]
'SELECT * FROM submolts WHERE name = $1',
[normalizedName]
);

if (!submolt) {
throw new NotFoundError('Submolt');
throw new NotFoundError(`m/${normalizedName}`);
}

// If agentId is provided, get the user's role separately
if (agentId) {
const modRole = await queryOne(
'SELECT role FROM submolt_moderators WHERE submolt_id = $1 AND agent_id = $2',
[submolt.id, agentId]
);
submolt.your_role = modRole ? modRole.role : null;
} else {
submolt.your_role = null;
}

return submolt;
Expand Down