Support $XDG_CONFIG_HOME #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikw
force-pushed
the
feature/3/xdg_spec
branch
from
20fe917 to
d75c193
Compare
erikw
added a commit
to erikw/cd-bookmark
that referenced
this pull request
Nov 4, 2021
The missing piece for this shell program: easily delete bookmarkas as well without having to being faced with all bookmarks with the -e edit command. When one know the BOOKMARK_ID, it should be as easy as $ cd-bookmark -d BOOKMAK_ID to remove it! Fixes mollifier#5
Backwards compatible change that supports storing the bookmarks in $XDG_CONFIG_HOME/cd-bookmarks. * If the user as set the previously existing $CD_BOOKMARK_FILE, this is always overriding. * If the user has created the directory/file $XDG_CONFIG_HOME/cd-bookmarks/(bookmarks), use this * Else fall back to old default $HOME/.cdbookmark Fixes mollifier#3
erikw
force-pushed
the
feature/3/xdg_spec
branch
from
d75c193 to
fff0479
Compare
erikw
added a commit
to erikw/cd-bookmark
that referenced
this pull request
Nov 4, 2021
The missing piece for this shell program: easily delete bookmarkas as well without having to being faced with all bookmarks with the -e edit command. When one know the BOOKMARK_ID, it should be as easy as $ cd-bookmark -d BOOKMAK_ID to remove it! Fixes mollifier#5
erikw
added a commit
to erikw/cd-bookmark
that referenced
this pull request
Nov 4, 2021
The missing piece for this shell program: easily delete bookmarkas as well without having to being faced with all bookmarks with the -e edit command. When one know the BOOKMARK_ID, it should be as easy as $ cd-bookmark -d BOOKMAK_ID to remove it! Fixes mollifier#5
erikw
added a commit
to erikw/cd-bookmark
that referenced
this pull request
Nov 4, 2021
The missing piece for this shell program: easily delete bookmarkas as well without having to being faced with all bookmarks with the -e edit command. When one know the BOOKMARK_ID, it should be as easy as $ cd-bookmark -d BOOKMAK_ID to remove it! Fixes mollifier#5
erikw
added a commit
to erikw/cd-bookmark
that referenced
this pull request
Nov 4, 2021
The missing piece for this shell program: easily delete bookmarkas as well without having to being faced with all bookmarks with the -e edit command. When one know the BOOKMARK_ID, it should be as easy as $ cd-bookmark -d BOOKMAK_ID to remove it! Fixes mollifier#5
erikw
added a commit
to erikw/cd-bookmark
that referenced
this pull request
Nov 4, 2021
The missing piece for this shell program: easily delete bookmarkas as well without having to being faced with all bookmarks with the -e edit command. When one know the BOOKMARK_ID, it should be as easy as $ cd-bookmark -d BOOKMAK_ID to remove it! Fixes mollifier#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible change that supports storing the bookmarks in
$XDG_CONFIG_HOME/cd-bookmarks.$CD_BOOKMARK_FILE, this is always overriding.$XDG_CONFIG_HOME/cd-bookmarks/(bookmarks), use this$HOME/.cdbookmarkThus $XDG_CONFIG_HOME is opt-in for those who want. This logic can be changed in a couple of releases to migrate away from $HOME/.cdbookmark.
Tested on zsh
5.8on macOS.Fixes #3