Update all remaining deps#73
Closed
CodexHere wants to merge 2 commits intomoleculerjs:masterfrom
CodexHere:updateAllRemainingDeps
Closed
Update all remaining deps#73CodexHere wants to merge 2 commits intomoleculerjs:masterfrom CodexHere:updateAllRemainingDeps
CodexHere wants to merge 2 commits intomoleculerjs:masterfrom
CodexHere:updateAllRemainingDeps
Conversation
* Updated minimal dependencies to get operational: * nats * inquirer - the main culprit of double characters * eslint and associative plugins * jest for experimental VM Module import support * npm-check - was missing but used in npm scripts * Updated eslintrc to refer to ECMA 2022 for dynamic import features used within * Updated importing `inquirer` using dynamic import * Required a few changes to keep order of operations in check, mainly `await`ing import adhoc. * With changes to using a dynamic import, JEST required node to be executed with `NODE_OPTIONS=--experimental-vm-modules` * See: https://jestjs.io/docs/ecmascript-modules * Removed a few unused references in files touched * Updated create.spec to mock with changes due to dynamic import, and doing so in a `beforeEach` functional block to remove redundancy
…ate. This required minor changes to the code to dynamically import ESM modules in a CJS context
Contributor
|
@icebob Any chance someone can take a look at reviewing these changes? I think there are several dependencies which are out of date. |
Member
|
Thanks, the #74 will contain these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating the minimum required packages in Pull #72, I updated the rest of the dependencies to get everything up to date.